Debugging the cause of random PGP failures

[laeubi]

FYI @merks

[github-actions]

Test Results

  579 files  ±0    579 suites  ±0   4h 7m 28s ⏱️ + 20m 50s
  392 tests ±0    384 ✅  - 1   7 💤 ±0  1 ❌ +1 
1 176 runs  ±0  1 151 ✅  - 3  22 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit c76b4cd. ± Comparison against base commit e3e1b60.

♻️ This comment has been updated with latest results.

[merks]

It failed. Yeah!

[laeubi]

The log says:

INFO] Trying to get the private key of the secret key of public key: ae85fc855206fc089735b2daf449ee9525282a89
[INFO] Got the private key of the secret key of public key: ae85fc855206fc089735b2daf449ee9525282a89
[DEBUG] [2265462a-cad2-496c-a82e-9c0249eaf205][extension>org.eclipse.tycho:tycho-maven-plugin:5.0.0-SNAPSHOT] Searching bundle for class interface org.eclipse.equinox.p2.core.IProvisioningAgent and location file:/C:/Users/runneradmin/.m2/repository/org/eclipse/platform/org.eclipse.equinox.p2.core/2.10.200/org.eclipse.equinox.p2.core-2.10.200.jar
[DEBUG] [2265462a-cad2-496c-a82e-9c0249eaf205][extension>org.eclipse.tycho:tycho-maven-plugin:5.0.0-SNAPSHOT] Return bundle org.eclipse.equinox.p2.core for location file:/C:/Users/runneradmin/.m2/repository/org/eclipse/platform/org.eclipse.equinox.p2.core/2.10.200/org.eclipse.equinox.p2.core-2.10.200.jar
[DEBUG] Enter loading repository file:/D:/a/tycho/tycho/tycho-its/target/projects/TestPGPSigning/testSigningSkipIfJarSignedAndAnchored/gpg.sign.p2.basic/site/target/repository
[DEBUG] Exit loading repository file:/D:/a/tycho/tycho/tycho-its/target/projects/TestPGPSigning/testSigningSkipIfJarSignedAndAnchored/gpg.sign.p2.basic/site/target/repository
[DEBUG] D:\a\tycho\tycho\tycho-its\target\projects\TestPGPSigning\testSigningSkipIfJarSignedAndAnchored\gpg.sign.p2.basic\site\target\repository\plugins\org.eclipse.equinox.common_3.16.200.v20220817-1601.jar is already signed and signed jars should be skipped if anchored!
[DEBUG] D:\a\tycho\tycho\tycho-its\target\projects\TestPGPSigning\testSigningSkipIfJarSignedAndAnchored\gpg.sign.p2.basic\site\target\repository\plugins\org.eclipse.osgi.source_3.18.100.v20220817-1601.jar is already signed and signed jars should be skipped if anchored!
[DEBUG] D:\a\tycho\tycho\tycho-its\target\projects\TestPGPSigning\testSigningSkipIfJarSignedAndAnchored\gpg.sign.p2.basic\site\target\repository\plugins\org.eclipse.osgi_3.18.100.v20220817-1601.jar is already signed and signed jars should be skipped if anchored!
[DEBUG] D:\a\tycho\tycho\tycho-its\target\projects\TestPGPSigning\testSigningSkipIfJarSignedAndAnchored\gpg.sign.p2.basic\site\target\repository\binary\org.eclipse.platform_root_4.25.0.v20220831-1800 is a binary and these should be skipped!
[DEBUG] Expanding: D:\a\tycho\tycho\tycho-its\target\projects\TestPGPSigning\testSigningSkipIfJarSignedAndAnchored\gpg.sign.p2.basic\site\target\repository\artifacts.jar into D:\a\tycho\tycho\tycho-its\target\projects\TestPGPSigning\testSigningSkipIfJarSignedAndAnchored\gpg.sign.p2.basic\site\target\repository
[DEBUG] expand complete

Does this help in any way?

[laeubi]

It failed. Yeah!

I now tried to adjust the failing method in the following way:

1. Check that all unsigned IUs are actually jar signed
2. Check that all singed IUs are actually NOT jar signed
3. Check that only one item is neither included in (1) or (2) ( == the root file)

I think this should replicate what the test wanted to assert @merks @mickaelistria but without using hard coded set of IU names?

[merks]

Keep in mind jar-signed but not anchored case. I’m away from the computer so can’t look in detail.

[laeubi]

I now successfully broke all PGP test (while the test locally succeeds) so it seems more that calling the check for signature itself seem to influence later checks ....

[laeubi]

I now successfully broke all PGP test (while the test locally succeeds) so it seems more that calling the check for signature itself seem to influence later checks ....

Because some has hard coded checks to the org.eclipse.platform_root ...