Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest): create new enpoint to upload component csv file. #2308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(rest): create new enpoint to upload component csv file. #2308

wants to merge 1 commit into from

Conversation

nikkuma7
Copy link
Contributor

@nikkuma7 nikkuma7 commented Feb 12, 2024 •
edited by GMishx
Loading

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Closes #2307

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

1: Login with admin access
2: Go to admin tab and check in ImportExport subtab.
3: upload componetFile/releaseFile/componentAttachment file and file type will be .csv

URL: http://localhost:8080/resource/api/importExport/componentAttachment
URL: http://localhost:8080/resource/api/importExport/uploadRelease
URL: http://localhost:8080/resource/api/importExport/uploadComponent

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for has merge conflicts labels Mar 15, 2024
@heliocastro heliocastro added the New-UI Level for the API and UI level changes for the new-ui label Mar 27, 2024
@eldrin30 eldrin30 self-assigned this May 7, 2024
@GMishx
Copy link
Member

GMishx commented Sep 6, 2024

@nikkuma7 please rebase with latest main

@nikkuma7
Copy link
Contributor Author

Done. Rebase with latest main.

GMishx
GMishx requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change needed.

...c/main/java/org/eclipse/sw360/rest/resourceserver/importexport/Sw360ImportExportService.java Outdated Show resolved Hide resolved
...c/main/java/org/eclipse/sw360/rest/resourceserver/importexport/Sw360ImportExportService.java Outdated Show resolved Hide resolved
GMishx
GMishx previously approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Please rebase once @nikkuma7

@GMishx
Copy link
Member

GMishx commented Oct 21, 2024

@rudra-superrr please help with testing this PR.

@rudra-superrr
Copy link
Contributor

Rest docs are broken.
image

@nikkuma7
Copy link
Contributor Author

nikkuma7 commented Nov 3, 2024

Rest docs are broken. image

done.

@rudra-superrr
Copy link
Contributor

Docs are still broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx left review comments

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@rudra-superrr rudra-superrr

@eldrin30 eldrin30

Labels
needs general test This is general testing, meaning that there is no org specific issue to check for New-UI Level for the API and UI level changes for the new-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(rest): create new enpoint to upload component csv file.
6 participants
@nikkuma7 @GMishx @rudra-superrr @heliocastro @ag4ums @eldrin30