Update inversify #477
Merged
Update inversify #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spoenemann |
7 tasks
spoenemann
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inversify dependency in sprotty is locked to 6.0.x. This version is now pretty outdated and there have been a lot of improvements in inversify.js that we can not consume yet.
In addition, this hardlock might block downstream projects.
In GLSP for instance, we might integrate into other components that also use inversify.js (e.g. Theia).
Unfortunately, dependency injection breaks if multiple different inversify.js versions are resolved so we have to align this.
This change updates to the latest inversify.js version (using 6.1.3 as minimum version same as in Theia)