Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge label placement #455

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

gfontorbe
Copy link
Contributor

There was a bug where edge labels that do not contain an edgePlacement property would be positioned incorrectly

Signed-off-by: Guillaume Fontorbe <[email protected]>
@gfontorbe gfontorbe requested review from spoenemann and jbicker May 17, 2024 08:49
Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfontorbe gfontorbe merged commit 8eb479f into master May 28, 2024
2 checks passed
@gfontorbe gfontorbe deleted the gfontorbe/fix-edge-label-placement branch May 28, 2024 07:40
@spoenemann spoenemann added this to the v1.3.0 milestone Jun 4, 2024
spoenemann pushed a commit that referenced this pull request Jun 4, 2024
Signed-off-by: Guillaume Fontorbe <[email protected]>
spoenemann pushed a commit that referenced this pull request Jun 4, 2024
Signed-off-by: Guillaume Fontorbe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants