Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supports for shadow DOM #435

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Add supports for shadow DOM #435

merged 2 commits into from
Feb 21, 2024

Conversation

gfontorbe
Copy link
Contributor

Closes #425

Adds an option in the ViewerOptions to add the id of the element that holds the shadow root.

The viewer will first check if this option is set before trying to retrieve the div container for the diagram.

Signed-off-by: Guillaume Fontorbe <[email protected]>
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@spoenemann spoenemann added this to the v1.2.0 milestone Feb 21, 2024
Signed-off-by: Guillaume Fontorbe <[email protected]>
@gfontorbe gfontorbe merged commit 6c77394 into master Feb 21, 2024
2 checks passed
@gfontorbe gfontorbe deleted the gfontorbe/shadow-dom branch February 21, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support shadow dom
2 participants