Move edge labels #411
Merged
Move edge labels #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freely or constrain them to the edge
jbicker
force-pushed
the
jbicker/labels-allow-to-move-edge-55
branch
from
84804b9 to
a0681b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration option for enhanced label positioning related to edges. It adds the possibility to move labels along the edge or completely free. Or set the moveMode to none to not move a certain label at all.
The move feature must be enabled in the di config for make label placement work.
For type-safe edge placement, the corresponding element type in the sprotty model must be extended with EdgeLayoutable type.
If edgePlacement is not specified, the label is placed at default position, with the exception that labels can be freely moved.
When edgePlacement is configured and moveMode is set to 'none', labels will not be moveable.
If edgePlacement is set and moveMode is 'edge', labels are constrained to movement along the associated edge. This also serves as the default behavior when moveMode is undefined.
When edgePlacement is configured and moveMode is 'free', labels can be moved freely in any direction.