Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID for edge in progress after connect #405

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

dhuebner
Copy link
Contributor

@dhuebner dhuebner commented Nov 15, 2023

When connecting a new created edge inside the applyReconnect function a new valid and unique id will be set instead of generic edge-in-progress. Doing so the new edge will remain visible after an update.

I tested the behavior with the random-graph example project. See dh/test-392-random-graph branch. Note: In the example only ports without a connection can be connected.

See #392

@dhuebner dhuebner force-pushed the dh/edge-in-progress branch from 524520e to 69a562b Compare November 15, 2023 15:03
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on the branch you mentioned and got this when I tried to create two connections:

Error: Duplicate ID in model: edge-in-progress-target-anchor

Sometimes I also saw an other issue where the edge-in-progress does not follow the mouse cursor, but is shifted by some amount 🤔

@dhuebner
Copy link
Contributor Author

@spoenemann
Yes, I notice it as well. Especially if one lose the focus (e.g. because of breakpoint) and goes back to the diagram. I don't think it is related to this change, but to the move handler. We need definitely look into it. I will spend some time to investigate it.

@spoenemann
Copy link
Contributor

Could you look into the edge-in-progress-target-anchor? Maybe we have to rename or remove that, too.

@dhuebner
Copy link
Contributor Author

They are normally removed automatically after you click somewhere. I don't think we should remove them right after reconnect. But maybe re-naming them is a good idea. We just need to make sure they are removed again when the edge is deselected.

@dhuebner dhuebner force-pushed the dh/edge-in-progress branch from 69a562b to 28e2219 Compare November 17, 2023 12:25
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spoenemann spoenemann added this to the v1.1.0 milestone Nov 20, 2023
@dhuebner dhuebner merged commit e38e5d4 into master Nov 20, 2023
2 checks passed
@dhuebner dhuebner deleted the dh/edge-in-progress branch November 20, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants