-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ID for edge in progress after connect #405
Conversation
524520e
to
69a562b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested on the branch you mentioned and got this when I tried to create two connections:
Error: Duplicate ID in model: edge-in-progress-target-anchor
Sometimes I also saw an other issue where the edge-in-progress does not follow the mouse cursor, but is shifted by some amount 🤔
@spoenemann |
Could you look into the |
They are normally removed automatically after you click somewhere. I don't think we should remove them right after reconnect. But maybe re-naming them is a good idea. We just need to make sure they are removed again when the edge is deselected. |
69a562b
to
28e2219
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
When connecting a new created edge inside the
applyReconnect
function a new valid and unique id will be set instead of genericedge-in-progress
. Doing so the new edge will remain visible after an update.I tested the behavior with the random-graph example project. See dh/test-392-random-graph branch. Note: In the example only ports without a connection can be connected.
See #392