Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SModelExtension interface #389

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Remove SModelExtension interface #389

merged 2 commits into from
Oct 6, 2023

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Oct 6, 2023 •
edited
Loading

Remove the empty SModelExtension interface and adapt type doc of feature extension interfaces.

Fixes #387

@tortmayr
Remove SModelExtension interface
9a029c6 
Remove the empty `SModelExtensionInterface` and adapt type doc
of feature extension interfaces.

Fixes #387
@tortmayr tortmayr requested a review from spoenemann October 6, 2023 12:33
spoenemann
spoenemann approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/sprotty/src/features/move/model.ts Outdated Show resolved Hide resolved
@tortmayr tortmayr merged commit 044bba2 into master Oct 6, 2023
1 check passed
@tortmayr tortmayr deleted the pr/387 branch October 6, 2023 13:11
@spoenemann spoenemann added this to the v1.0.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoenemann spoenemann spoenemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Remove SModelExtension interface
2 participants
@tortmayr @spoenemann