Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed ViewportRootElement #381

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Renamed ViewportRootElement #381

merged 2 commits into from
Oct 5, 2023

Conversation

spoenemann
Copy link
Contributor

The following changes are for consistency with the new naming scheme:

  • Renamed ViewportRootElement class to ViewportRootElementImpl
  • Renamed ViewportRootElementSchema interface to ViewportRootElement and moved to sprotty-protocol package.

@spoenemann spoenemann added this to the v1.0.0 milestone Sep 29, 2023
@planger
Change to ViewportRootElementImpl in viewport test
42b2c22 
Change-Id: If030a1469895acfe69a0792ffba2be09cb6cf2e5
@planger planger self-requested a review October 4, 2023 19:00
planger
planger approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one more usage in a test that hasn't been adapted and fixed in 42b2c22.
Looks great now! Thank you!

@spoenemann spoenemann merged commit 6488b8f into master Oct 5, 2023
1 check passed
@spoenemann spoenemann deleted the viewport-model branch October 5, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planger planger planger approved these changes

@dhuebner dhuebner Awaiting requested review from dhuebner

@tortmayr tortmayr Awaiting requested review from tortmayr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@spoenemann @planger