Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing of Implicit Plugin-Dpendencies #1475

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Nov 13, 2024

Currently editing the Implicit Plugin-Dpendencies only seem to work randomly (e.g. if one change some other property along with the change).

This now do not refresh the full target (what seem to reset the underlying model and remove the dirty flag before changes are applied) but only updates the UI so finally these thing appear in the target file.

Fixes #451

Copy link

github-actions bot commented Nov 13, 2024

Test Results

   285 files  ±0     285 suites  ±0   50m 31s ⏱️ - 2m 43s
 3 586 tests ±0   3 510 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 950 runs  ±0  10 719 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit 2b05e09. ± Comparison against base commit bb04e28.

♻️ This comment has been updated with latest results.

Currently editing the Implicit Plugin-Dpendencies only seem to work
randomly (e.g. if one change some other property along with the change).

This now do not refresh the full target (what seem to reset the
underlying model and remove the dirty flag before changes are applied)
but only updates the UI so finally these thing appear in the target
file.

Fixes eclipse-pde#451
@laeubi laeubi force-pushed the issue_451_edit_impossible branch from eef9ee0 to 2b05e09 Compare December 1, 2024 06:39
@laeubi
Copy link
Contributor Author

laeubi commented Dec 4, 2024

Merging as the new issues are caused by:

@laeubi laeubi merged commit b8ce236 into eclipse-pde:master Dec 4, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[target] Implicit Plugin Dependencies is broken
1 participant