Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Added changes to display CPU Governors in Javacore #3348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bharathappali
Copy link
Contributor

@bharathappali bharathappali commented Oct 18, 2018

As stated in the issue #2838 CPU Governors in linux might be useful for debugging purposes and thought it would be good to have that information in javacore.

The current changes adds a J9 Port Library api j9sysinfo_get_cpu_governor_info which fetch the CPU governor information and this will be called in runtime/rasdump/javadump.cpp in writeCPUInfo function.

These lines are added after CPU Information to get the CPU Governor Details

1CICPUGINF     CPU Governor Information
NULL           ------------------------------------------------------------------------
2CICPUGPOWS    CPUS with Powersave Governor : /* list the cpus which have Powersave governor */
2CICPUGPERF    CPUS with Performance Governor : /* list the cpus which have Performance governor */
2CICPUGURSP    CPUS with User Space Governor : /* list the cpus which have User Space governor */
2CICPUGONDM    CPUS with On Demand Governor : /* list the cpus which have On Demand governor */
2CICPUGCONS    CPUS with Conservative Governor : /* list the cpus which have Conservative governor */
2CICPUGSCUT    CPUS with Sched Util Governor : /* list the cpus which have Sched Util governor */

Example

1CICPUINFO     CPU Information
NULL           ------------------------------------------------------------------------
2CIPHYSCPU     Physical CPUs: 4
2CIONLNCPU     Online CPUs: 4
2CIBOUNDCPU    Bound CPUs: 4
2CIACTIVECPU   Active CPUs: 0
2CITARGETCPU   Target CPUs: 4
NULL           
1CICPUGINF     CPU Governor Information
NULL           ------------------------------------------------------------------------
2CICPUGPOWS    CPUS with Powersave Governor : 0 1 2 3 

In the above example there are 4 cpu's and each of them are having their cpu scaling governor set to powersave

Note: This features are work in progress as the way of information representation may have changes.
Please kindly add your views on this PR or in the issue #2838

FYI - @ashu-mehra @DanHeidinga
Thanks

Doc issue eclipse-openj9/openj9-docs#136

Signed-off-by: bharathappali [email protected]

@bharathappali
Copy link
Contributor Author

Refactoring the code. Will be updating for review after the code changes are done.

@bharathappali bharathappali force-pushed the javacore-cpu-governors branch 2 times, most recently from 2b22efc to 781af4e Compare December 10, 2018 08:04
@bharathappali bharathappali force-pushed the javacore-cpu-governors branch 3 times, most recently from 2caf761 to ff13e31 Compare December 19, 2018 11:16
@bharathappali bharathappali force-pushed the javacore-cpu-governors branch 2 times, most recently from 2085e58 to 3299404 Compare January 7, 2019 04:38
@bharathappali bharathappali force-pushed the javacore-cpu-governors branch 2 times, most recently from a8653f7 to 4b8ed32 Compare January 22, 2019 10:04
@bharathappali bharathappali force-pushed the javacore-cpu-governors branch 2 times, most recently from d49d71c to 132a6ca Compare March 13, 2019 02:54
@pshipton
Copy link
Member

pshipton commented Jul 8, 2019

Moving forward until this picks up again.

@genie-openj9
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants