Comment that JVM_DoPrivileged should not be removed #20846
Conversation
|
You'll need to remove the rest of it, from exports.cmake, j9vmnatives.xml, forwarders.m4 |
|
Also pls check jdk8 or 11 or both, with an internal build on Windows, since Windows isn't working for PR builds. |
|
Actually check jdk8 Windows on vmfarm, I'm not sure if we can remove this. |
|
You're right. It worked with linux 8,11,17,next that I ran previously but caused a Windows vmfarm build to fail compilation. I will add a comment to this method that it shouldn't be removed since its not obvious searching through the OpenJ9 code base. |
theresa-m
force-pushed
the
remove_doprivileged
branch
from
6f6b759 to
d1e8424
Compare
theresa-m
changed the title
|
Linux uses dynamic linking and won't fail for a missing symbol until runtime. Windows does static linking and fails during the build. I agree JVM_DoPrivileged is not used/not called, but although we've optimized Semeru to remove the code that calls it, things are different for IBM Java 8. |
runtime/j9vm/j7vmi.c
Outdated
| @@ -380,7 +380,7 @@ java_lang_J9VMInternals_doPrivilegedWithException(JNIEnv* env) | |||
| return cached; | |||
| } | |||
|
|
|||
|
|
|||
| /* Do not remove: this method is used in Windows Java 8 vmfarm builds. */ | |||
There was a problem hiding this comment.
Not sure "used" is accurate. It should never be called, but there is code that links to it.
There was a problem hiding this comment.
Pls use "Windows IBM Java 8" or similar. I don't think vmfarm should be used, the build platform may change (perhaps it will be jenkins in the future) but the link issue will persist unless the IBM Java 8 JCL code is modified.
Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
remove_doprivileged
branch
from
d1e8424 to
3d586dd
Compare
|
Could we make the definition and exports conditional ( |
No description provided.