Avoid shared lambda form statics name comparison #20845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When lambda form sharing is enabled, distinct lambda forms can end up with identical names and signatures, since that option causes the non-deterministic address suffix in their name to be replaced with a NULL address. Thus, the existing name comparison in TR_ResolvedJ9JITServerMethod::staticsAreSame() could cause distinct lambda forms to be identified together inappropriately, leading to crashes in remotely-compiled code. The new code instead always treats two lambda forms with identical names as being distinct, relying on the existing fallback in TR_J9ServerVM::jitStaticsAreSame() to ensure that equal lambda forms are correctly identified as such. Signed-off-by: Christian Despres <[email protected]>
|
Attn @mpirvu. |
|
jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit,alinux64jit jdk21 |
|
xlinux sanity.functional: floatSanityTests_1 crash |
|
10x grinder for the floatSanityTests: https://openj9-jenkins.osuosl.org/job/Grinder/4035/ |
|
The grinder passed and I don't have reasons to believe the problem was introduced by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lambda form sharing is enabled, distinct lambda forms can end up with identical names and signatures, since that option causes the non-deterministic address suffix in their name to be replaced with a NULL address. Thus, the existing name comparison in TR_ResolvedJ9JITServerMethod::staticsAreSame() could cause distinct lambda forms to be identified together inappropriately, leading to crashes in remotely-compiled code. The new code instead always treats two lambda forms with identical names as being distinct, relying on the existing fallback in TR_J9ServerVM::jitStaticsAreSame() to ensure that equal lambda forms are correctly identified as such.