Update ClassLoader.findNative to support JEP 472 #20840
Merged
+45
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new version of ClassLoader.findNative has been introduced, which accepts the Java method name and the Java class where the native method is declared as input parameters. It performs native access checks to comply with JEP 472 (Prepare to Restrict the Use of JNI). Related: eclipse-openj9#19680 Related: eclipse-openj9#20354 Signed-off-by: Babneet Singh <[email protected]>
|
@tajila Requesting your review. |
tajila
reviewed
Dec 17, 2024
| static long findNative(ClassLoader loader, String entryName) { | ||
| /*[IF JAVA_SPEC_VERSION >= 24]*/ | ||
| static long findNative1(ClassLoader loader, String entryName, Class<?> cls, String javaName) { | ||
| long address = findNative0(loader, entryName); |
There was a problem hiding this comment.
Does the spec specify this order of checks? As in, if we look for a method that doesnt exist in a class that doesnt have native access, which error shows up?
There was a problem hiding this comment.
The spec does not explicitly define the order of checks, but we can infer it from the available OpenJDK tests. Currently, we are aligned with the RI since we pass the majority of failing tests in #20354.
|
jenkins test sanity alinux64 jdk24 |
|
@babsingh are the failure known failures? |
Many are related to the missing Vthread pinning support, while other failures are unrelated to these changes. All the failing tests in #20354 are passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version of
ClassLoader.findNativehas been introduced, whichaccepts the Java method name and the Java class where the native
method is declared as input parameters. It performs native access
checks to comply with JEP 472 (Prepare to Restrict the Use of JNI).
Related: #19680
Related: #20354