Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK24 adds JavaLangAccess.virtualThreadDelayedTaskSchedulers() #20745

Merged
merged 1 commit into from
Dec 4, 2024
Merged

JDK24 adds JavaLangAccess.virtualThreadDelayedTaskSchedulers() #20745

merged 1 commit into from
Dec 4, 2024

Conversation

JasonFengJ9
Copy link
Member

@JasonFengJ9 JasonFengJ9 commented Dec 4, 2024 •
edited by keithc-ca
Loading

JDK24 adds JavaLangAccess.virtualThreadDelayedTaskSchedulers() and removes GetPropertyAction.

Required by

Signed-off-by: Jason Feng [email protected]

@JasonFengJ9 JasonFengJ9 requested a review from keithc-ca December 4, 2024 13:27
@JasonFengJ9 JasonFengJ9 mentioned this pull request Dec 4, 2024
Merged
@keithc-ca
Copy link
Contributor

This will not be sufficient: GetPropertyAction is removed from JDK24 and so CRIUConfigurator must be updated accordingly.

@JasonFengJ9
Copy link
Member Author

Removed GetPropertyAction usage from CRIUConfigurator.

keithc-ca
keithc-ca requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message and the description here to reflect the increased scope of this change.

jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java Outdated Show resolved Hide resolved
@JasonFengJ9
JDK24 adds JavaLangAccess.virtualThreadDelayedTaskSchedulers()
1ec0984 
Also removed sun.security.action.GetPropertyAction.

Signed-off-by: Jason Feng <[email protected]>
@keithc-ca keithc-ca merged commit c568611 into eclipse-openj9:master Dec 4, 2024
2 checks passed
@JasonFengJ9 JasonFengJ9 deleted the jdk24access branch December 4, 2024 19:50
@hangshao0
Copy link
Contributor

Seems that this is causing Valhalla build to fail.

@JasonFengJ9
Copy link
Member Author

Seems that this is causing Valhalla build to fail.

I will try to merge the latest openjdk updates, otherwise the virtualThreadDelayedTaskSchedulers() should be excluded for Valhalla.

@JasonFengJ9
Copy link
Member Author

Merged the OpenJDK updates, the latest JDKnext_x86-64_linux_valhalla_Nightly now passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
comp:vm jdk24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonFengJ9 @keithc-ca @hangshao0