Value type null-restricted array support #20132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitripivkine
approved these changes
Sep 9, 2024
theresa-m
added
comp:vm
project:valhalla
5 tasks
keithc-ca
requested changes
Sep 9, 2024
- create a null-restricted array field for every RAM class if one doesn't exist when a null-restricted array is created - implement JVM_IsNullRestrictedArray and JVM_NewNullRestrictedArray - Update exception thrown when null is set to a null-restricted array from NullPointerException to ArrayStoreException as described in https://openjdk.org/jeps/8316779 Signed-off-by: Theresa Mammarella <[email protected]>
The purpose of this change is to keep value type command line tests passing until they are updated and the vm fully enables flattening of null-restricted arrays. Signed-off-by: Theresa Mammarella <[email protected]>
Signed-off-by: Theresa Mammarella <[email protected]>
It is possible there could be a mixed (non-array) class as _iterateArrayClass in GC_ClassLoaderClassesIterator::nextArrayClass. Make sure _iterateArrayClass gets set to null when all array classes have been found to prevent an infinite loop. Signed-off-by: Theresa Mammarella <[email protected]>
keithc-ca
approved these changes
Sep 9, 2024
|
Jenkins test sanity,extended zlinuxval jdknext |
|
Jenkins test sanity amac jdk21 |
hangshao0
approved these changes
Sep 9, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is being resubmitted from #19911 with the only change being the most recent commit. The commit prevents infinite looping in GC_ClassLoaderClassesIterator::nextArrayClass by ensuring
_iterateArrayClassis reset to NULL at the end of a loop.Personal builds:
http://vmfarm.rtp.raleigh.ibm.com/build_info.php?build_id=77569
https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/23806/
Please note this pull request adds support to create a null-restricted array but not a flattened array. That will come in a later change.
Related: #17340
Fixes: #19460
After these changes: