[FFI] Remove all code & test suites tagged with J9VM_OPT_PANAMA #19862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR has been verified in personal builds (internal & open) on all supported platforms. Reviewer: @keithc-ca |
ChengJin01
added
comp:vm
project:panama
|
Jenkins test sanity amac jdk11,jdk23 |
keithc-ca
requested changes
Jul 17, 2024
|
For the record, testing passed at https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/5841. |
The changes remove the stale code & tests tagged with J9VM_OPT_PANAMA in JDK16 given all FFI related functionalities were fully implemented in which case the code & test surrounded by or related to J9VM_OPT_PANAMA are no longer required for any reference. Signed-off-by: ChengJin01 <[email protected]>
ChengJin01
force-pushed
the
ffi_remove_stale_panama_code
branch
from
a58f8c6 to
950eec7
Compare
keithc-ca
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes remove the stale code & tests tagged with
J9VM_OPT_PANAMAin JDK16 given all FFI related functionalities were fully implemented
in which case the code & test surrounded by or related to
J9VM_OPT_PANAMAare no longer required for any reference.Signed-off-by: ChengJin01 [email protected]
Fixes: #10377.