[FFI] Adjust the code with the release of the thunk heap #19852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to consolidate part of the existing FFI specific code before tackling the issue with duplicate ffi_type for struct in #19714. The PR has been verified in personal builds on all supported platform. Reviewer: @tajila |
ChengJin01
added
comp:vm
project:panama
keithc-ca
requested changes
Jul 12, 2024
ChengJin01
force-pushed
the
ffi_code_adjustment_free_thunk_heap
branch
from
332e2b3 to
d2dae55
Compare
|
Jenkins test sanity amac jdk21 |
ChengJin01
force-pushed
the
ffi_code_adjustment_free_thunk_heap
branch
from
d2dae55 to
08c0469
Compare
The changes move the code intended for the release of thunk heap to UpcallThunkMem.cpp so as to consolidate the code specific to the thunk heap operations to one place, which includes: 1) move freeUpcallMetaDataDoFn() to UpcallThunkMem.cpp 2) move alll the code with the release of the thunk heap in freeJavaVM() to releaseThunkHeap() at UpcallThunkMem.cpp Related: eclipse-openj9#19714 Signed-off-by: ChengJin01 <[email protected]>
ChengJin01
force-pushed
the
ffi_code_adjustment_free_thunk_heap
branch
from
08c0469 to
4b6f2fd
Compare
|
I don't think the recent source changes invalidate the testing done in https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/5823. |
keithc-ca
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes move the code intended for the release of thunk heap
to
UpcallThunkMem.cppso as to consolidate the code specific tothe thunk heap operations to one place, which includes:
freeUpcallMetaDataDoFn()toUpcallThunkMem.cppin
freeJavaVM()toreleaseThunkHeap()atUpcallThunkMem.cppRelated: #19714
Signed-off-by: ChengJin01 [email protected]