Array base offset zero #19326
Merged
Array base offset zero #19326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test sanity alinux64 |
|
jenkins test sanity alinux64 jdk17 |
|
jenkins test sanity alinux64 jdk17 |
|
jenkins test sanity xlinux jdk21 |
tajila
force-pushed
the
offheap
branch
6 times, most recently
from
96a05ce to
b49b911
Compare
|
jenkins test sanity alinux64 jdk17 |
tajila
force-pushed
the
offheap
branch
3 times, most recently
from
3634715 to
c931198
Compare
|
jenkins test sanity alinux64 jdk17 |
|
jenkins test sanity xlinux64 jdk17 |
|
jenkins test sanity xlinux jdk17 |
tajila
force-pushed
the
offheap
branch
11 times, most recently
from
24513b0 to
f42b356
Compare
tajila
force-pushed
the
offheap
branch
13 times, most recently
from
544ffad to
34e44c7
Compare
|
jenkins test sanity alinux64 jdk17 |
|
@dmitripivkine @amicic @gacholio Please review |
gacholio
approved these changes
Jul 10, 2024
dmitripivkine
approved these changes
Jul 10, 2024
amicic
reviewed
Jul 11, 2024
|
@amicic changes ready for another look |
Looks good. Not obvious to me why you changed the C assert into a Java exception. Perphas put a comment in a commit or code. |
amicic
approved these changes
Jul 12, 2024
Set unsafe header offsets to zero when large offheap arrays are enabled. Replace assertation with exception in `compareAndExchangeObject` due avoid trace header includes in UnsafeAPI.hpp as that file is used in various modules. Signed-off-by: tajila <[email protected]>
|
jenkins test sanity alinux64 jdk8,jdk21 |
I updated the commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set unsafe header offsets to zero when large offheap arrays are enabled.
Replace assertation with exception in
compareAndExchangeObjectdueavoid trace header includes in UnsafeAPI.hpp as that file is used in
various modules.