Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make java.lang.Thread.container a known field #18460

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

babsingh
Copy link
Contributor

java.lang.Thread.container is added in vmconstantpool.xml.

Accessing java.lang.Thread.container as a known field simplifies
and fixes the incorrect error handling in getVirtualThreadState.

java.lang.Thread.container is added in vmconstantpool.xml.

Accessing java.lang.Thread.container as a known field simplifies
and fixes the incorrect error handling in getVirtualThreadState.

Signed-off-by: Babneet Singh <[email protected]>
@babsingh babsingh requested a review from gacholio November 16, 2023 02:19
@babsingh
Copy link
Contributor Author

@gacholio Requesting your review. It resolves the issue with error handling.

@babsingh
Copy link
Contributor Author

jenkins test sanity zlinux jdk21

@gacholio
Copy link
Contributor

CRIU failure unrelated to this change. @tajila Why are these failures not being excluded?

@gacholio gacholio merged commit 5688e72 into eclipse-openj9:master Nov 16, 2023
@tajila
Copy link
Contributor

tajila commented Nov 16, 2023

CRIU failure unrelated to this change. @tajila Why are these failures not being excluded?

Its a new test, we will exclude.

@tajila
Copy link
Contributor

tajila commented Nov 20, 2023

@babsingh You'll need to triple deliver to 0.42

@babsingh
Copy link
Contributor Author

@gacholio
Copy link
Contributor

Why the 0.43 ports?

@babsingh
Copy link
Contributor Author

Why the 0.43 ports?

0.43 is a Java 21 Jan refresh: https://github.com/eclipse-openj9/openj9/milestones.

@gacholio
Copy link
Contributor

Is that not a placeholder branch that will be refreshed from master? I wasn't asked to port anything to 0.43.

@pshipton
Copy link
Member

pshipton commented Nov 20, 2023

Anything that goes into 0.42 (Java 21.0.1 - the OpenJ9 GA) should also go into 0.43 which includes the 21.0.2 update.
@TobiAjila fyi

@pshipton
Copy link
Member

Is that not a placeholder branch that will be refreshed from master?

0.42 was a placeholder when we did M0, but since we branched Nov 14 for 0.42/0.43 M1 we need to start double/triple delivering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants