Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache instances of TemporaryLoggerFinder #18406

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Nov 6, 2023

Fixes #18405

@pshipton
Copy link
Member Author

pshipton commented Nov 6, 2023

jenkins compile alinux64 jdk17,jdk21,jdknext

@pshipton
Copy link
Member Author

pshipton commented Nov 6, 2023

jenkins compile alinux64 jdk17,jdknext

@pshipton
Copy link
Member Author

pshipton commented Nov 6, 2023

jenkins compile alinux64 jdk17,jdknext

@pshipton
Copy link
Member Author

pshipton commented Nov 6, 2023

jenkins compile alinux64 jdk17 depends ibmruntimes/openj9-openjdk-jdk17#openj9-staging

@pshipton
Copy link
Member Author

pshipton commented Nov 6, 2023

Tested via grinders.

jdk17: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3041/
jdk22: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3040/

java/lang/System/LoggerFinder/RecursiveLoading/PlatformRecursiveLoadingTest.java  Passed. Execution successful
java/lang/System/LoggerFinder/RecursiveLoading/RecursiveLoadingTest.java          Passed. Execution successful
java/lang/System/LoggerFinder/SignedLoggerFinderTest/SignedLoggerFinderTest.java  Passed. Execution successful

@pshipton
Copy link
Member Author

pshipton commented Nov 6, 2023

@keithc-ca this needs to be merged concurrently with promoting jdk17 (i.e. pushing openj9-staging to openj9). Either while we're still at the 17.0.10+1 level, or if we get a newer level then new acceptance testing is required first.

@keithc-ca keithc-ca merged commit 4acf608 into eclipse-openj9:master Nov 6, 2023
@keithc-ca
Copy link
Contributor

The openj9 branch of jdk17 is also advanced to 1cd3f35fa7e8a5aa460ef71888ccf377c4c4334f.

@pshipton
Copy link
Member Author

pshipton commented Nov 7, 2023

The openj9 branch of jdk17 is also advanced to 1cd3f35fa7e8a5aa460ef71888ccf377c4c4334f.

In fact it was not, at least for https://github.com/ibmruntimes/openj9-openjdk-jdk17. All the jdk17 builds failed last night. I've done it now.

@keithc-ca
Copy link
Contributor

I know I pushed it somewhere, perhaps it was to my fork rather than to https://github.com/ibmruntimes/openj9-openjdk-jdk17. Sorry.

pshipton added a commit to pshipton/openj9 that referenced this pull request Nov 16, 2023
The OpenJDK change has been backported to jdk11.
See eclipse-openj9#18406

Signed-off-by: Peter Shipton <[email protected]>
pshipton added a commit to pshipton/openj9 that referenced this pull request Nov 16, 2023
The OpenJDK change has been backported to jdk11.
See eclipse-openj9#18406

Signed-off-by: Peter Shipton <[email protected]>
pshipton added a commit to pshipton/openj9 that referenced this pull request Jan 18, 2024
pshipton added a commit to pshipton/openj9 that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jdk17 acceptance OpenJDK java/lang/System/LoggerFinder tests failing with StackOverflowError
2 participants