Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FFI/Test_JDK22] Add test suites intended for union #18388

Merged

Conversation

ChengJin01
Copy link

The changes add all the same test suites intended
for union in JDK21 to JDK22 with the updated APIs
introduced in JDK22.

Signed-off-by: ChengJin01 [email protected]

@ChengJin01
Copy link
Author

The changes (which are the same as the test suites for union at #18291)
are verified in personal builds (JDK21 & 22) on all supported platforms.

@ChengJin01
Copy link
Author

Reviewer: @tajila
FYI: @keithc-ca, @pshipton

@ChengJin01 ChengJin01 requested a review from tajila November 2, 2023 03:20
@ChengJin01 ChengJin01 added comp:test jdk22 project:panama Used to track Project Panama related work labels Nov 2, 2023
The changes add all the same test suites intended
for union in JDK21 to JDK22 with the updated APIs
introduced in JDK22.

Signed-off-by: ChengJin01 <[email protected]>
@ChengJin01 ChengJin01 force-pushed the ffi_add_test_suites_union_jdk22 branch from f58599b to c0f1b71 Compare November 2, 2023 18:17
@keithc-ca
Copy link
Contributor

Jenkins test sanity alinux jdk21

@keithc-ca
Copy link
Contributor

Jenkins test sanity aix,alinux,plinux,xlinux,zlinux,win jdk21,jdknext

@ChengJin01
Copy link
Author

[1] https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_ppc64_aix_Personal/12/artifact/Test_openjdknext_j9_sanity.functional_ppc64_aix_Personal_testList_1/12/aqa-tests/TKG/output_16989554223828/Test_openjdknext_j9_sanity.functional_ppc64_aix_Personal_testList_1.tap/*view*/

ok 44 - Jep454Tests_testLinkerFfi_DownCall_0
  ---
    duration_ms: 9176
  ...
ok 45 - Jep454Tests_testLinkerFfi_UpCall_0
  ---
    duration_ms: 5770

[2] https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_aarch64_linux_Personal/25/tapTestReport/

51 - - Jep454Tests_testLinkerFfi_DownCall_0 	8.2 sec	OK
60 - - Jep454Tests_testLinkerFfi_UpCall_0 	12 sec	OK

All Failed Tests
Test Name	Duration	Age
 227 - - Jep425Tests_testVirtualThread_1 	9.5 sec	
 228 - - Jep425Tests_testVirtualThread_2 	9.3 sec	
 71 - - cmdLineTester_criu_nonPortableRestore_4 	6 min 58 sec	
 138 - - Jep425Tests_testVirtualThread_0 	7.5 sec	
 139 - - Jep425Tests_testVirtualThread_3 	7.5 sec	

which means the failing tests in the builds above are irrelevant to our test suites.

@ChengJin01
Copy link
Author

ChengJin01 commented Nov 2, 2023

[1] https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.functional_s390x_linux_Personal/50/tapTestReport/

42 - - Jep442Tests_testLinkerFfi_DownCall_0 	23 sec	OK	
49 - - Jep442Tests_testLinkerFfi_UpCall_0 	3.8 sec	OK

[2] https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_s390x_linux_Personal/41/tapTestReport/

15 - - Jep454Tests_testLinkerFfi_DownCall_0 	11 sec	OK	
230 - - Jep454Tests_testLinkerFfi_UpCall_0 	12 sec	OK	

[3]https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_x86-64_windows_Personal_testList_0/18/tapTestReport/
https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_x86-64_windows_Personal_testList_1/18/tapResults/

63 - - Jep442Tests_testLinkerFfi_DownCall_0 	8.7 sec	OK
129	- Jep442Tests_testLinkerFfi_UpCall_0	duration_ms	5860 OK

[4] https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_x86-64_linux_Personal/33/tapTestReport/

8 - - Jep454Tests_testLinkerFfi_UpCall_0 	13 sec	OK	
98 - - Jep454Tests_testLinkerFfi_DownCall_0 	14 sec	OK

Copy link
Contributor

@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only changes tests and all those tests passed.

@keithc-ca keithc-ca merged commit 6378d21 into eclipse-openj9:master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:test jdk22 project:panama Used to track Project Panama related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants