Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add addition testing for ThreadMXBean thread alloc #18365

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Add addition testing for ThreadMXBean thread alloc #18365

merged 1 commit into from
Nov 2, 2023

Conversation

tajila
Copy link
Contributor

@tajila tajila commented Oct 27, 2023

Add new test cases to verify non-current thread paths.

Depends on eclipse-omr/omr#7163

@tajila tajila requested a review from babsingh October 27, 2023 20:30
@pshipton
Copy link
Member

pshipton commented Oct 27, 2023 •
edited
Loading

Test in grinders
jdk8 - https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3010/ - failed
jdk11 - https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3011/ - failed

@pshipton
Copy link
Member

@TobiAjila the test grinders failed

@pshipton
Copy link
Member

Arg, I missing the OMR dependency.

@pshipton
Copy link
Member

jenkins compile alinux64 jdk8,jdk11 depends eclipse-omr/omr#7163

@pshipton pshipton marked this pull request as draft October 27, 2023 20:53
@pshipton
Copy link
Member

Set as draft until the OMR change is promoted.

@pshipton
Copy link
Member

Grinders are passing now.
jdk8 https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3015/
jdk11 https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3014/

@tajila
Copy link
Contributor Author

tajila commented Nov 1, 2023

@pshipton can we retest this now?

@pshipton pshipton marked this pull request as ready for review November 1, 2023 21:04
@pshipton
Copy link
Member

pshipton commented Nov 1, 2023

The OMR change is promoted. I don't think it needs to be re-tested. Just reviewed and merged.

@pshipton
Copy link
Member

pshipton commented Nov 1, 2023

It's not hard to retest anyway, here are some passing alinux grinders using the last nightly build.
jdk8 - https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3033/
jdk11 - https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3032/

@tajila
Copy link
Contributor Author

tajila commented Nov 2, 2023

@babsingh please review/merge

@tajila
Copy link
Contributor Author

tajila commented Nov 2, 2023

@babsingh changes ready for another look, https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3033/tapResults/

babsingh
babsingh reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits. otherwise, lgtm.

test/functional/JLM_Tests/src/org/openj9/test/java/lang/management/TestThreadMXBean.java Outdated Show resolved Hide resolved
test/functional/JLM_Tests/src/org/openj9/test/java/lang/management/TestThreadMXBean.java Outdated Show resolved Hide resolved
@tajila
Add addition testing for ThreadMXBean thread alloc
32039bb 
Add new test cases to verify non-current thread paths.

Depends on eclipse-omr/omr#7163

Signed-off-by: Tobi Ajila <[email protected]>
@babsingh
Copy link
Contributor

babsingh commented Nov 2, 2023

Started new grinders:

babsingh
babsingh approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both latest grinders have passed.

@babsingh
Copy link
Contributor

babsingh commented Nov 2, 2023

eca check has also passed but it isn't reflected in the PR. @AdamBrousseau this is a recurring issue. do our scripts need to be updated?

@babsingh babsingh merged commit 59eb37d into eclipse-openj9:master Nov 2, 2023
@AdamBrousseau
Copy link
Contributor

That's an Eclipse check. Seems like it isn't poking back successfully to the GH PR. If it's a problem we can raise an issue for them to follow up.
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsingh babsingh babsingh approved these changes

Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tajila @pshipton @babsingh @AdamBrousseau