Fix Tree Simplifier convertCurrentTimeMillis() #18312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The convertCurrentTimeMillis() function was recreating a currentTimeMillis() call into a new call target which would be replaced in codegen with a Z specific instruction. To convert the results into milliseconds the value has to be divided by a constant and the tree was incorrectly converted into an ldiv with a call child that is not anchored which allowed dead trees elimination to remove the treetop resulting in the the ldiv to be moved in a way that would change the semantic of the java method. Signed-off-by: Kevin Langman <[email protected]>
|
Jenkins test sanity all jdk11 |
vijaysun-omr
approved these changes
Oct 19, 2023
|
@vijaysun-omr the machines at unb aren't usable atm, see the announcement on Slack |
|
jenkins test sanity zlinuxjit jdk21 |
|
Checks have passed except on aix that does not look like a real issue. This is a cross platform change anyway that looks safe to me. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convertCurrentTimeMillis() function was recreating a currentTimeMillis() call into a new call target which would be replaced in codegen with a Z specific instruction. To convert the results into milliseconds the value has to be divided by a constant and the tree was incorrectly converted into an ldiv with a call child that is not anchored which allowed dead trees elimination to remove the treetop resulting in the the ldiv to be moved in a way that would change the semantic of the java method.