Eliminate tautological comparisons #18261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzongaro
reviewed
Oct 12, 2023
hzongaro
reviewed
Oct 13, 2023
dylanjtuttle
force-pushed
the
tautologicalCompare
branch
from
2e88ff4 to
262f0b2
Compare
mpirvu
reviewed
Oct 13, 2023
Fix an AIX warning concerning tautological comparisons (i.e. boolean comparisons which will always evaluate to the same value) by eliminating them Signed-off-by: Dylan Tuttle <[email protected]>
dylanjtuttle
force-pushed
the
tautologicalCompare
branch
from
262f0b2 to
7be404a
Compare
hzongaro
approved these changes
Oct 14, 2023
|
Marius @mpirvu, if you're OK with this change now, may I ask you to mark your approval? |
|
Running a subset of platforms to avoid too much pressure on Jenkins servers. Jenkins test sanity zlinux,aix,alinux,win jdk17 |
|
Looks like Windows failure was due to an infrastructure issue. Restarting: Jenkins test sanity win jdk17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an AIX warning concerning tautological comparisons (i.e. boolean comparisons which will always evaluate to the same value) by eliminating them. In both situations, variables with type
UDATA(which is an unsigned data type and would therefore never be negative) were compared with zero.This PR contributes to (but does not close) #14859