Support new GAV of plexus-build-api

[laeubi]

See codehaus-plexus/plexus-build-api@9c2e013

codehaus-plexus/plexus-build-api#21

We could simply have both APIs supported.

[HannesWell]

See codehaus-plexus/plexus-build-api@9c2e013

codehaus-plexus/plexus-build-api#21

We could simply have both APIs supported.

The dependency can be added/changed here (just in case you didn't already know :) ):

m2e-core/m2e-maven-runtime/org.eclipse.m2e.maven.runtime/pom.xml

Line 74 in 4df09e6

<groupId>org.sonatype.plexus</groupId>

If the fully-qualified names did not change we have to or can use that as drop in replacement.

[kwin]

@laeubi Is something still missing in master...laeubi:m2e-core:issue_944_new_plexus_api or can we include this in the upcoming release?

[laeubi]

It is at least missing that I need to finish/finalize that :-)

[laeubi]

@gnodet @kwin if you like to speed this up, the most critical part (for me) currently is that we do not have good test-coverage but high impact if we break things.
So if we can have some test in https://github.com/eclipse-m2e/m2e-core/tree/master/org.eclipse.m2e.core.tests that cover the functionality this would help a lot, I already tried before getting an integration-test with a dummy-maven plugin but can't get it reliable working that a plugin compiled in the current reactor is used in a test.

[gnodet]

@laeubi the branch does not build anymore from the command line.
I end up with

[ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.0-SNAPSHOT:compare-version-with-baselines (check-no-version-regression) on project org.eclipse.m2e.model.edit: Version have moved backwards for (org.eclipse.m2e.model.edit/2.0.200.20230130-0743). Baseline has 2.0.300.20230320-2130) with delta: 0.0.-100 -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.0-SNAPSHOT:compare-version-with-baselines (check-no-version-regression) on project org.eclipse.m2e.model.edit: Version have moved backwards for (org.eclipse.m2e.model.edit/2.0.200.20230130-0743). Baseline has 2.0.300.20230320-2130) with delta: 0.0.-100

but there's no references to either version in the source tree.

[gnodet]

Also and fwiw, the project does not load correctly in IntelliJ (all the Tyco projects are not recognised) nor Eclipse Java (class path does not seem to be initialised correctly).

I've done quite a lof to OSGi development in the past, but not using Tycho, Eclipse or M2e, so I'm not familiar with the whole setup.

[laeubi]

M2E is an eclipse project so Eclipse IDE is somehow a requirement (even though it might work to some degree with IntelliJ).

You can setup a Dev-IDE here:
https://github.com/eclipse-m2e/m2e-core/blob/master/CONTRIBUTING.md#%EF%B8%8F-setting-up-the-development-environment-automatically-using-the-eclipse-installer-oomph

Regarding the branch, the best would be to just start from the master and as a first step add a test-case before try to apply any of the changes this can then be merged already as a prerequisite and will show that the dev-workflow works already.

If we have this I can rebase my branch ontop of this to see if it already breaks something, and add support for the new GAV.