read composite on root path #1520
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| /******************************************************************************* | ||
| * Copyright (c) 2013-2015 Sierra Wireless and others. | ||
| * | ||
| * All rights reserved. This program and the accompanying materials | ||
| * are made available under the terms of the Eclipse Public License v2.0 | ||
| * and Eclipse Distribution License v1.0 which accompany this distribution. | ||
| * | ||
| * The Eclipse Public License is available at | ||
| * http://www.eclipse.org/legal/epl-v20.html | ||
| * and the Eclipse Distribution License is available at | ||
| * http://www.eclipse.org/org/documents/edl-v10.html. | ||
| * | ||
| * Contributors: | ||
| * Orange Polska S.A. - initial API and implementation | ||
| *******************************************************************************/ | ||
| package org.eclipse.leshan.core.node; | ||
|
|
||
| import java.util.Collection; | ||
| import java.util.Collections; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.TreeMap; | ||
|
|
||
| public class LwM2mRoot implements LwM2mNode { | ||
| private final Map<Integer, LwM2mObject> objects; | ||
|
|
||
| public LwM2mRoot(Collection<LwM2mObject> objects) { | ||
| LwM2mNodeUtil.validateNotNull(objects, "objects MUST NOT be null"); | ||
| HashMap<Integer, LwM2mObject> objectsMap = new HashMap<>(objects.size()); | ||
| for (LwM2mObject object : objects) { | ||
| LwM2mObject previous = objectsMap.put(object.getId(), object); | ||
| if (previous != null) { | ||
| throw new LwM2mNodeException( | ||
| "Unable to create LwM2mRoot : there are several objects with the same id %d", object.getId()); | ||
| } | ||
| } | ||
| this.objects = Collections.unmodifiableMap(objectsMap); | ||
| } | ||
|
|
||
| @Override | ||
| public int getId() { | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public void accept(LwM2mNodeVisitor visitor) { | ||
| visitor.visit(this); | ||
| } | ||
|
|
||
| @Override | ||
| public String toPrettyString(LwM2mPath path) { | ||
| return appendPrettyNode(new StringBuilder(), path).toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public StringBuilder appendPrettyNode(StringBuilder b, LwM2mPath path) { | ||
| if (!path.isRoot()) | ||
| throw new IllegalArgumentException("Path must be a root path"); | ||
| if (path.getObjectId() != getId()) | ||
| throw new IllegalArgumentException("Path id must match this LwM2mMultipleResource id"); | ||
|
|
||
| if (objects.isEmpty()) { | ||
| b.append(path).append(" : {}"); | ||
| } else { | ||
| boolean first = true; | ||
| for (Map.Entry<Integer, LwM2mObject> entry : new TreeMap<>(objects).entrySet()) { | ||
| if (first) { | ||
| first = false; | ||
| } else { | ||
| b.append("\n"); | ||
| } | ||
| entry.getValue().appendPrettyNode(b, path.append(entry.getKey())); | ||
| } | ||
| } | ||
| return b; | ||
| } | ||
|
|
||
| public Map<Integer, LwM2mObject> getObjects() { | ||
| return objects; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) { | ||
| if (this == obj) | ||
| return true; | ||
| if (obj == null) | ||
| return false; | ||
| if (getClass() != obj.getClass()) | ||
| return false; | ||
| LwM2mRoot other = (LwM2mRoot) obj; | ||
| if (objects == null) { | ||
| if (other.objects != null) | ||
| return false; | ||
| } else if (!objects.equals(other.objects)) | ||
| return false; | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| final int prime = 31; | ||
| int result = 1; | ||
| result = prime * result + getId(); | ||
| result = prime * result + ((objects == null) ? 0 : objects.hashCode()); | ||
| return result; | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I think some check should be done here.
The spec says :
(http://www.openmobilealliance.org/release/LightweightM2M/V1_1_1-20190617-A/HTML-Version/OMA-TS-LightweightM2M_Core-V1_1_1-20190617-A.html#6-3-8-0-638-Read-Composite-Operation)
So I think on failure, we should not stop the read-composite operation but just log as error.
(so error will not be seen at server side)