feature: Add update API for generated specifications #27
Conversation
closes eclipse-kuksa#23 Signed-Off-By: Mark Hüsers <[email protected]>
If some classes could not be processed then these should be skipped instead of retrying the generation.
These add a lot of convenience to the usage of manipulating values inside these models. No one has to remember the correct copy method now.
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/VssSpecificationCopyExtension.kt
Outdated
Show resolved
Hide resolved
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/VssSpecificationCopyExtension.kt
Show resolved
Hide resolved
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/VssSpecificationCopyExtension.kt
Show resolved
Hide resolved
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/VssSpecificationCopyExtension.kt
Outdated
Show resolved
Hide resolved
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/VssSpecificationCopyExtension.kt
Outdated
Show resolved
Hide resolved
| DEFAULT_FILE_NAME, | ||
| classDeclaration.toClassName().simpleName + FILE_NAME_PROCESSOR_POSTFIX, |
There was a problem hiding this comment.
Could you shortly elaborate the purpose of this change?
classDeclaration should be the class which is annotated by the VssDefinition class, so in our case it would be KuksaDataBrokerActivityProcessor...?
There was a problem hiding this comment.
Correct. It eliminates an issue where you could annotate two different classes and kapt will then throw an error.
There was a problem hiding this comment.
Understood, but will it then also process everything twice, because it found the same annotation (with same or different spec file) twice?
Expectation: That should not work and should in fact throw a meaningful exception.
There was a problem hiding this comment.
If the specification has the same information for a model then it will throw an exception. If it does not (an extension file for example) it should work (did not test that one yet). We will probably have to support that in the near future anyway and can test it then and create a ticket if something is missing.
vss-processor/src/main/kotlin/org/eclipse/kuksa/vssprocessor/VssDefinitionProcessor.kt
Outdated
Show resolved
Hide resolved
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/DataPointExtension.kt
Show resolved
Hide resolved
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/VssSpecificationExtension.kt
Outdated
Show resolved
Hide resolved
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/DataBrokerConnection.kt
Outdated
Show resolved
Hide resolved
- The plus operator (which replaced a child inside a parent) was now replaced with the invoke operator. Plus and so on are now properly adding values together for numbers.
# Conflicts: # kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/DataBrokerConnection.kt
- Add the update method for vssSpecifications again. The DataBrokerConnection from the main was used for the initial fix of the conflicts.
...a-sdk/src/main/kotlin/org/eclipse/kuksa/extension/vssProperty/VssPropertyBooleanExtension.kt
Show resolved
Hide resolved
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/vssProperty/VssPropertyDoubleExtension.kt
Show resolved
Hide resolved
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/vssProperty/VssPropertyFloatExtension.kt
Show resolved
Hide resolved
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/vssProperty/VssPropertyIntExtension.kt
Show resolved
Hide resolved
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/vssProperty/VssPropertyLongExtension.kt
Show resolved
Hide resolved
Multiple onPropertyChanged updates from different threads may be called. The updatedVssSpecification must be in sync however. Calling the .copy in a blocking context is necessary for this.
The documentation of the newSingleThreadContext recommends the usage of Dispatcher.limitedParallelism in our case.
|
@lukasmittag @SebastianSchildt |
Very similar to the subscribe logic but calls "update" on every child property. The PR also adds a lot of convenience API for developers who are using the generated specifications.