Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Kuksa SDK Snapshot Builds to MavenLocal #13

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Publish Kuksa SDK Snapshot Builds to MavenLocal #13

merged 4 commits into from
Oct 9, 2023

Conversation

wba2hi
Copy link
Contributor

@wba2hi wba2hi commented Oct 4, 2023

Closes: #6

@wba2hi
feature: Add Centralized Versioning
f83fd55 
The version is centrally stored inside the $rootDir/version.properties.

The version can be controlled purely with gradle. Therefore the
following Gradle tasks were added in the "version" group of the
rootProject:
- increaseMajorVersion
- increaseMinorVersion
- increasePatchVersion
- printVersion
- printVersionCode
- setReleaseVersion
- setSnapshotVersion
@wba2hi
Copy link
Contributor Author

wba2hi commented Oct 4, 2023

Had to force push due to failing commitlint task

@Chrylo
Copy link
Contributor

Chrylo commented Oct 9, 2023 •
edited
Loading

LGTM @SebastianSchildt Wie need a OK here.
Some adaption will be made in #4 to also allow publications for Java modules.

lukasmittag
lukasmittag approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok from my side too. Only had a quick look at the code and not an expert here. But looks good from what I can say :)

@lukasmittag lukasmittag merged commit d724aba into eclipse-kuksa:main Oct 9, 2023
3 checks passed
@Chrylo Chrylo deleted the feature-6 branch October 11, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmittag lukasmittag lukasmittag approved these changes

@Chrylo Chrylo Chrylo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish Kuksa SDK Snapshot Builds to MavenLocal
3 participants
@wba2hi @Chrylo @lukasmittag