Add dataType property to VssSignal #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UInt could not be used before this commit because @jvmoverloads was used for all generated VSS data classes. Since UInt is a Kotlin specific data type it was incompatible with the annotation. As long as we are only using one constructor param for VssSignals we can remove the annotation because the default constructor will still be available. Note: The java byte code will still show an Int for the Kotlin UInt model. This is fine as long as the SDK is speaking Kotlin while interacting with these models. close eclipse-kuksa#93
VssNodeSpecModel: - Adds now an experimental annotation for some data types so warnings are properly ignored. - The generation code of the VssSignal now iterates through the member properties of the interface and generates the correct implementation. The VssHeartRate for integration tests is currently the only VssSignal which has a different dataType (UInt) than the value type (Int).
wba2hi
requested changes
Mar 18, 2024
kuksa-sdk/src/test/kotlin/org/eclipse/kuksa/connectivity/databroker/DataBrokerConnectionTest.kt
Outdated
Show resolved
Hide resolved
vss-core/src/main/kotlin/org/eclipse/kuksa/vsscore/model/VssNode.kt
Outdated
Show resolved
Hide resolved
vss-processor/src/main/kotlin/org/eclipse/kuksa/vssprocessor/spec/VssNodeSpecModel.kt
Outdated
Show resolved
Hide resolved
vss-processor/src/main/kotlin/org/eclipse/kuksa/vssprocessor/spec/VssNodeSpecModel.kt
Outdated
Show resolved
Hide resolved
vss-processor/src/main/kotlin/org/eclipse/kuksa/vssprocessor/spec/VssNodeSpecModel.kt
Outdated
Show resolved
Hide resolved
vss-processor/src/test/kotlin/org/eclipse/kuksa/vssprocessor/spec/VssNodeSpecModelTest.kt
Outdated
Show resolved
Hide resolved
vss-processor/src/test/kotlin/org/eclipse/kuksa/vssprocessor/spec/VssNodeSpecModelTest.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # kuksa-sdk/src/test/kotlin/org/eclipse/kuksa/connectivity/databroker/DataBrokerConnectionTest.kt
wba2hi
requested changes
Mar 19, 2024
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/DataPointExtension.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/eclipse/kuksa/testapp/databroker/JavaDataBrokerEngine.java
Show resolved
Hide resolved
kuksa-sdk/src/test/kotlin/org/eclipse/kuksa/connectivity/databroker/DataBrokerConnectionTest.kt
Outdated
Show resolved
Hide resolved
kuksa-sdk/src/main/kotlin/org/eclipse/kuksa/extension/DataPointExtension.kt
Outdated
Show resolved
Hide resolved
wba2hi
reviewed
Mar 19, 2024
vss-processor/src/main/kotlin/org/eclipse/kuksa/vssprocessor/spec/VssNodeSpecModel.kt
Outdated
Show resolved
Hide resolved
wba2hi
reviewed
Mar 19, 2024
vss-processor/src/main/kotlin/org/eclipse/kuksa/vssprocessor/spec/VssNodeSpecModel.kt
Outdated
Show resolved
Hide resolved
wba2hi
reviewed
Mar 19, 2024
vss-processor/src/main/kotlin/org/eclipse/kuksa/vssprocessor/spec/VssNodeSpecModel.kt
Outdated
Show resolved
Hide resolved
wba2hi
reviewed
Mar 19, 2024
vss-processor/src/main/kotlin/org/eclipse/kuksa/vssprocessor/spec/VssNodeSpecModel.kt
Show resolved
Hide resolved
wba2hi
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UInt, and all other inline data types, can't be used if we want to be Java compatible. So this PR introduces a new property for generated VssSignals which tells the SDK how to convert the the actual value of the VssSignal to the expected type for the DataBroker.
VssNodeSpecModel:
are properly ignored.
properties of the interface and generates the correct
implementation.
close #93