Improve completion for binary infix operator #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
force-pushed
the
dom-with-javac
branch
from
2ad1e11 to
f45e071
Compare
datho7561
force-pushed
the
dom-with-javac-completino-in-binary-operator
branch
2 times, most recently
from
91b1e16 to
4665375
Compare
datho7561
changed the title
datho7561
force-pushed
the
dom-with-javac-completino-in-binary-operator
branch
from
4665375 to
888e191
Compare
|
Going to merge this if the test failures go down |
In order to accomplish this, I have changed the logic for adjusting the offset used for the node search. This causes some regressions: - A few cases where the test expects the AST not to be recovered but javac does recover it (eg. org.eclipse.jdt.core.tests.model.CompletionTests_1_5.test0197) - @| in Javadoc is not handled. Before it got no completion due to not finding the correct node, but now it gets default completion, which causes some regressions. I'll fix these when dealing with @| properly - The test cases sometimes expect the current class to be suggested in new | completion even when the type doesn't match, but sometimes they don't. I'll need to investigate further Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
dom-with-javac-completino-in-binary-operator
branch
from
888e191 to
657896c
Compare
|
Test failures go up by the expected amount (5 new passes 6 new failures, net 1 new failure), merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to accomplish this,I have changed the logic for adjusting the offset used for the node search.
This causes some regressions:
org.eclipse.jdt.core.tests.model.CompletionTests_1_5.test0197)@|in Javadoc is not handled. Before it got no completion due to not finding the correct node, but now it gets default completion, which causes some regressions. I'll fix these when dealing with@|properlynew |completion even when the type doesn't match, but sometimes they don't. I'll need to investigate further