Do not generate false positive unused parameter warning

[akurtakov]

The following cases are fixed:

• Interface methods
• Abstract methods
• Methods marked with Override annotation

[datho7561]

The number of test failures increased by 30. I'll try to get the list of new failures (unfortunately this is a manual process so far).

[akurtakov]

The number of test failures increased by 30. I'll try to get the list of new failures (unfortunately this is a manual process so far).

Interesting, do you see anything that might cause them in the PR itself?

[datho7561]

My initial guess was a null check missing somewhere. However it seems that there are some failures in CompletionTests18 that are listed twice. This doesn't make sense to me, but it could be the culprit.

[datho7561]

eg. CompletionTests18.test492947b is listed three times: twice as 'javac specific tests' and once as 'Build and Test'

[akurtakov]

I've rerun the build as I don't see any relation between what you pointed and the PR.

[akurtakov]

https://ci.eclipse.org/ls/job/jdt-core-incubator/job/PR-925/2/ has 1313 failing tests while head of dom-with-javac branch has 1312 tests https://ci.eclipse.org/ls/job/jdt-core-incubator/job/dom-with-javac/603/ . Aka failures are not caused by this patch.

[akurtakov]

Merging as per previous comment.