Improve completion in extends/implements #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
commented
Oct 24, 2024
datho7561
commented
- Change dom conversion logic to recover incomplete type names properly
- Restrict the suggested classes based on if they are a class or interface
- Do not suggest final classes
- Do not suggest the current class
datho7561
force-pushed
the
dom-with-javac-completion-in-extends-implements
branch
from
12dc491 to
be46dfc
Compare
- Change dom conversion logic to recover incomplete type names properly - Restrict the suggested classes based on if they are a class or interface - Do not suggest final classes - Do not suggest the current class Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
dom-with-javac-completion-in-extends-implements
branch
from
be46dfc to
eb98570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.