Use one default completion strategy #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
force-pushed
the
dom-with-javac
branch
from
7b4b9ad to
e230daa
Compare
- Remove 'suitable binding' completion - Fixes to package completionsome - Skip suggesting the default package - Use the same strategy whenever packages are suggested - Improve calculation of the prefix to make the matches more accurate - Potentially address dupliate type completions Fixes eclipse-jdt#870 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
dom-with-javac-one-default-completion
branch
from
21fd3e6 to
935c2c4
Compare
|
Merging; this fixes many test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #870