Attempt to share/deduplicate jar contents #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
force-pushed
the
cache-jars
branch
7 times, most recently
from
b3e1f9b to
f6f2f40
Compare
Introduce a subclass of JavacFileManager that is capable of caching and sharing jar contents. Also ensure some references are removed from context upon usage to encourage garbage collection. Note that JDK content is still duplicated as it's using another filemanager that seems harder to configure, using direct call to `PlatformUtils.lookupPlatformDescription().getFileManager()`. Also note that the cached entries only get disposed when all filemanagers are closed/GCed.
mickaelistria
force-pushed
the
cache-jars
branch
from
f6f2f40 to
f96c4d7
Compare
mickaelistria
merged commit d9c0beb
into
eclipse-jdtls:dom-with-javac
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a subclass of JavacFileManager that is capable of caching and sharing jar contents.
Note that JDK content is still duplicated as it's using another filemanager that seems harder to configure.
Also note that the cached entries never get disposed at the moment.