Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some "wrong type" quick fixes #558

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix some "wrong type" quick fixes #558

merged 1 commit into from
Jul 3, 2024

Conversation

datho7561
Copy link

  • add arguments to the created problem
    • This is needed to get the quick fixes to show up in JDT UI
  • Fix resolveBinding(Expression) for method invocations (it now properly returns the binding for the return type)
    • This fixes the "change variable type" quickfix

@datho7561
Fix some "wrong type" quick fixes
bca5308 
- add arguments to the created problem
  - This is needed to get the quick fixes to show up in JDT UI
- Fix resolveBinding(Expression) for method invocations (it now properly
  returns the binding for the return type)
  - This fixes the "change variable type" quickfix

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 force-pushed the dom-with-javac-type-mismatch-quickfix branch from 87059bf to bca5308 Compare July 3, 2024 16:20
@datho7561
Copy link
Author

This seems to keep the number of DOM conversion failures constant, so I'll merge

@datho7561 datho7561 merged commit 9fb207c into eclipse-jdtls:dom-with-javac Jul 3, 2024
2 of 4 checks passed
@datho7561 datho7561 deleted the dom-with-javac-type-mismatch-quickfix branch July 3, 2024 18:06
@mickaelistria
Copy link

This last patch seems to cause 38 regressions in JDT-LS test cases: https://ci.eclipse.org/ls/job/jdt-ls-javac/161/ .

@datho7561
Copy link
Author

Seems like I'll have to add some null checks

datho7561 added a commit that referenced this pull request Jul 5, 2024
@datho7561
Fix regression caused by #558
e0c1db8 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Jul 8, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
1cad254 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Jul 8, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
83aa3bf 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Jul 15, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
2edb624 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Jul 16, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
409b5c9 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
akurtakov pushed a commit that referenced this pull request Jul 19, 2024
@datho7561 @akurtakov
Fix regression caused by #558
eed236c 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Jul 25, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
75b34d9 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Jul 25, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
d326752 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
akurtakov pushed a commit that referenced this pull request Jul 29, 2024
@datho7561 @akurtakov
Fix regression caused by #558
b4f4adc 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
akurtakov pushed a commit that referenced this pull request Aug 16, 2024
@datho7561 @akurtakov
Fix regression caused by #558
12cf102 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Sep 5, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
88a29dc 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Sep 10, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
220cac1 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Sep 18, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
52a1583 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Sep 24, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
7c21490 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Sep 25, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
a16d423 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Oct 15, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
7e3afd1 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
rgrunber pushed a commit that referenced this pull request Oct 18, 2024
@datho7561 @rgrunber
Fix regression caused by #558
008e7da 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Oct 23, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
df758b1 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Nov 12, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
7beb27a 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Dec 5, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
58b8d2e 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Dec 6, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
f105f08 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit that referenced this pull request Dec 13, 2024
@datho7561
Fix regression caused by #558
732626b 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Dec 15, 2024
@datho7561 @mickaelistria
Fix regression caused by #558
bccc7d9 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
mickaelistria pushed a commit that referenced this pull request Jan 6, 2025
@datho7561 @mickaelistria
Fix regression caused by #558
a5edac9 
Both the "create new method" and the "add cast to method invocation"
cases should work now.

Signed-off-by: David Thompson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@datho7561 datho7561

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datho7561 @mickaelistria