Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-static JavacProblem converter #550

Conversation

mickaelistria
Copy link

No description provided.

Rob Stryker and others added 30 commits June 20, 2024 19:20
My resolve change accessed an entry set in order to access some JavaFileObjects, however this set doesn't necessarily have the same order as the array of CompilationUnits I was reading from, which caused the wrong rawText to be passed in during conversion

Signed-off-by: David Thompson <[email protected]>
The fix tries to group all source output mapping by the binary path and
compile each source files belonging to a single binary path separately.
Signed-off-by: Rob Stryker <[email protected]>
…s must be in correct order

Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
…ons with parenthesis handled incorrectly

Signed-off-by: Rob Stryker <[email protected]>
…lassInstanceCreation were skipped

Signed-off-by: Rob Stryker <[email protected]>
…annot be created in early jls versions

Signed-off-by: Rob Stryker <[email protected]>
mickaelistria and others added 26 commits June 25, 2024 11:27
the main branch doesn't compile,
it also needs these changes

Signed-off-by: David Thompson <[email protected]>
- `respondBinding` is now a misnomer, it just adds it to the list
  unconditionally instead of responding.
  It's also trivial. As such I removed it and inlined the relevant code
- we no longer need to pass around the list of desired keys;
  we must collect all keys so that we can respond to any request.
  I was able to remove a few parameters here and there as a result.

Signed-off-by: David Thompson <[email protected]>
+ Fix JavacTypeBinding.isFromSource()
* Generic is the type declaration with generics (eg Collection<E>)
* Raw is without any type parameter (eg Collection)
* Parameterized is a specialization of a generic type (eg
Collection<String>)
- This should also reduce the number of test failures

Signed-off-by: David Thompson <[email protected]>
* fix some bindings
* Fix javac/JDT problem mapping
* Add JavacBindingResolver.resolveMethod(SuperMethodInvocation)
* Hack to set source range on arrays dimensions
This should also fix the Quick fixes:
- add `throws` declaration
- surround with try/catch

Signed-off-by: David Thompson <[email protected]>
(these quickfixes are for abstract methods with bodies).

- The range of the body needs to be correct in order for it to work
- Also fix the range of the diagnostic

Signed-off-by: David Thompson <[email protected]>
* Javadoc stuff
* ranges for FieldAccess that are not packages
* Improve support for error type
@mickaelistria
Copy link
Author

Was merged a few days ago as b8c8b50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants