forked from eclipse-jdt/eclipse.jdt.core
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Un-static JavacProblem converter #550
Closed
mickaelistria
wants to merge
350
commits into
eclipse-jdtls:dom-with-javac
from
mickaelistria:un-static-problemConverter
Closed
Un-static JavacProblem converter #550
mickaelistria
wants to merge
350
commits into
eclipse-jdtls:dom-with-javac
from
mickaelistria:un-static-problemConverter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
…rked malformed Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
… incorrectly Signed-off-by: Rob Stryker <[email protected]>
My resolve change accessed an entry set in order to access some JavaFileObjects, however this set doesn't necessarily have the same order as the array of CompilationUnits I was reading from, which caused the wrong rawText to be passed in during conversion Signed-off-by: David Thompson <[email protected]>
The fix tries to group all source output mapping by the binary path and compile each source files belonging to a single binary path separately.
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
…s must be in correct order Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
…ons with parenthesis handled incorrectly Signed-off-by: Rob Stryker <[email protected]>
…lassInstanceCreation were skipped Signed-off-by: Rob Stryker <[email protected]>
…annot be created in early jls versions Signed-off-by: Rob Stryker <[email protected]>
…tion missing arguments Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: David Thompson <[email protected]>
Signed-off-by: David Thompson <[email protected]>
Signed-off-by: David Thompson <[email protected]>
the main branch doesn't compile, it also needs these changes Signed-off-by: David Thompson <[email protected]>
Signed-off-by: David Thompson <[email protected]>
- `respondBinding` is now a misnomer, it just adds it to the list unconditionally instead of responding. It's also trivial. As such I removed it and inlined the relevant code - we no longer need to pass around the list of desired keys; we must collect all keys so that we can respond to any request. I was able to remove a few parameters here and there as a result. Signed-off-by: David Thompson <[email protected]>
Signed-off-by: David Thompson <[email protected]>
+ Fix JavacTypeBinding.isFromSource()
Fixes eclipse-jdt#514 Signed-off-by: David Thompson <[email protected]>
Signed-off-by: David Thompson <[email protected]>
* Generic is the type declaration with generics (eg Collection<E>) * Raw is without any type parameter (eg Collection) * Parameterized is a specialization of a generic type (eg Collection<String>)
Signed-off-by: David Thompson <[email protected]>
…rsion Signed-off-by: David Thompson <[email protected]>
- This should also reduce the number of test failures Signed-off-by: David Thompson <[email protected]>
* fix some bindings * Fix javac/JDT problem mapping * Add JavacBindingResolver.resolveMethod(SuperMethodInvocation) * Hack to set source range on arrays dimensions
This should also fix the Quick fixes: - add `throws` declaration - surround with try/catch Signed-off-by: David Thompson <[email protected]>
(these quickfixes are for abstract methods with bodies). - The range of the body needs to be correct in order for it to work - Also fix the range of the diagnostic Signed-off-by: David Thompson <[email protected]>
* Javadoc stuff * ranges for FieldAccess that are not packages * Improve support for error type
mickaelistria
force-pushed
the
dom-with-javac
branch
from
July 2, 2024 08:50
206803d
to
b8c8b50
Compare
Was merged a few days ago as b8c8b50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.