Enable completion tests

- Fix some low hanging completion test errors

Signed-off-by: David Thompson <[email protected]>

org.eclipse.jdt.core.tests.javac/pom.xml

@@ -43,6 +43,7 @@
 						<configuration>
 							<includes>
 								<include>org/eclipse/jdt/core/tests/javac/RunConverterTestsJavac.class</include>
+								<include>org/eclipse/jdt/core/tests/javac/RunCompletionTestsJavac.class</include>
 							</includes>
 							<argLine>${tycho.surefire.argLine}</argLine>
 						</configuration>

org.eclipse.jdt.core.tests.javac/src/org/eclipse/jdt/core/tests/javac/RunCompletionTestsJavac.java

@@ -0,0 +1,19 @@
+/*******************************************************************************
+ * Copyright (c) 2024, Red Hat, Inc. and others.
+ *
+ * This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License 2.0
+ * which accompanies this distribution, and is available at
+ * https://www.eclipse.org/legal/epl-2.0/
+ *
+ * SPDX-License-Identifier: EPL-2.0
+ *******************************************************************************/
+package org.eclipse.jdt.core.tests.javac;
+
+public class RunCompletionTestsJavac extends org.eclipse.jdt.core.tests.model.RunCompletionModelTests {
+
+	public RunCompletionTestsJavac(String name) {
+		super(name);
+	}
+
+}

org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/DOMCompletionEngine.java

@@ -699,8 +699,6 @@ private CompletionProposal toProposal(IBinding binding, String completion) {
 					this.toComplete.getAST().resolveWellKnownType(Object.class.getName())) +
 				CompletionEngine.computeRelevanceForRestrictions(IAccessRule.K_ACCESSIBLE) + //no access restriction for class field
 				CompletionEngine.R_NON_INHERITED);
-		// set defaults for now to avoid error downstream
-		res.setRequiredProposals(new CompletionProposal[0]);
 		return res;
 	}
 
@@ -764,7 +762,6 @@ private CompletionProposal toImportProposal(char[] simpleName, char[] signature)
 		res.setSignature(signature);
 		res.completionEngine = this.nestedEngine;
 		res.nameLookup = this.nameEnvironment.nameLookup;
-		res.setRequiredProposals(new CompletionProposal[0]);
 		return res;
 	}
 
@@ -888,8 +885,6 @@ private CompletionProposal toModuleCompletion(String moduleName, char[] prefix)
 		proposal.completionEngine = this.nestedEngine;
 		proposal.nameLookup = this.nameEnvironment.nameLookup;
 
-		// set defaults for now to avoid error downstream
-		proposal.setRequiredProposals(new CompletionProposal[0]);
 		return proposal;
 	}
 
@@ -959,6 +954,7 @@ private CompletionProposal createKeywordProposal(char[] keyword, int startPos, i
 		}
 		CompletionProposal keywordProposal = createProposal(CompletionProposal.KEYWORD);
 		keywordProposal.setCompletion(keyword);
+		keywordProposal.setName(keyword);
 		keywordProposal.setReplaceRange(startPos, endPos);
 		keywordProposal.setRelevance(relevance);
 		return keywordProposal;