Use Import-Package instead of Require-Bundle for o.e.c.runtime to prevent importing unnecessary classes #3375
+10
−1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,16 @@ Bundle-Version: 3.40.100.qualifier | |
| Bundle-Activator: org.eclipse.jdt.core.JavaCore | ||
| Bundle-Vendor: %providerName | ||
| Bundle-Localization: plugin | ||
| Import-Package: org.eclipse.core.internal.runtime, | ||
|
There was a problem hiding this comment. Based on discussion at eclipse-equinox/equinox#697 , it looks like we can add |
||
| org.eclipse.core.runtime, | ||
| org.eclipse.core.runtime.content, | ||
| org.eclipse.core.runtime.jobs, | ||
| org.eclipse.core.runtime.preferences, | ||
| org.eclipse.equinox.app, | ||
| org.eclipse.osgi.service.debug, | ||
| org.eclipse.osgi.util, | ||
| org.osgi.framework, | ||
| org.osgi.service.prefs | ||
| Export-Package: org.eclipse.jdt.core, | ||
| org.eclipse.jdt.core.compiler, | ||
| org.eclipse.jdt.core.dom, | ||
|
|
@@ -43,7 +53,6 @@ Export-Package: org.eclipse.jdt.core, | |
| org.eclipse.jdt.internal.formatter.linewrap;x-friends:="org.eclipse.jdt.core.tests.model, org.eclipse.jdt.core.tests.compiler, org.eclipse.jdt.core.tests.builder, org.eclipse.jdt.core.tests.performance, org.eclipse.jdt.ui.tests", | ||
| org.eclipse.jdt.internal.formatter.old;x-friends:="org.eclipse.jdt.core.tests.model, org.eclipse.jdt.core.tests.compiler, org.eclipse.jdt.core.tests.builder, org.eclipse.jdt.core.tests.performance, org.eclipse.jdt.ui.tests" | ||
| Require-Bundle: org.eclipse.core.resources;bundle-version="[3.22.0,4.0.0)", | ||
| org.eclipse.core.filesystem;bundle-version="[1.11.0,2.0.0)", | ||
| org.eclipse.text;bundle-version="[3.6.0,4.0.0)", | ||
| org.eclipse.team.core;bundle-version="[3.1.0,4.0.0)";resolution:=optional, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why importing an internal package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also why are these imported without a version constraint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of internal packages was not introduced by this PR; it originates from existing code in jdt.core, which already references these internal packages.