Migrate ArtifactRepositoryComponent to DS annotations and property type

eclipse-equinox · Jan 5, 2025 · 0a32d95 · 0a32d95
1 parent 4b71cd1
commit 0a32d95
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 4 deletions.
diff --git a/...org.eclipse.equinox.p2.artifact.repository/.settings/org.eclipse.pde.ds.annotations.prefs b/...org.eclipse.equinox.p2.artifact.repository/.settings/org.eclipse.pde.ds.annotations.prefs
@@ -0,0 +1,7 @@
+dsVersion=V1_4
+eclipse.preferences.version=1
+enabled=true
+generateBundleActivationPolicyLazy=true
+path=OSGI-INF
+validationErrorLevel=error
+validationErrorLevel.missingImplicitUnbindMethod=error
diff --git a/bundles/org.eclipse.equinox.p2.artifact.repository/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.p2.artifact.repository/META-INF/MANIFEST.MF
@@ -69,7 +69,7 @@ Import-Package: javax.xml.parsers,
  org.osgi.service.prefs;version="1.1.1",
  org.w3c.dom,
  org.xml.sax;resolution:=optional
-Service-Component: OSGI-INF/repositoryManager.xml
+Service-Component: OSGI-INF/org.eclipse.equinox.p2.artifact.repository.xml
 Bundle-ActivationPolicy: lazy
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Automatic-Module-Name: org.eclipse.equinox.p2.artifact.repository
diff --git a/...repository/OSGI-INF/repositoryManager.xml → ...clipse.equinox.p2.artifact.repository.xml b/...repository/OSGI-INF/repositoryManager.xml → ...clipse.equinox.p2.artifact.repository.xml
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" name="org.eclipse.equinox.p2.artifact.repository">
+<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.4.0" name="org.eclipse.equinox.p2.artifact.repository">
    <implementation class="org.eclipse.equinox.internal.p2.artifact.repository.ArtifactRepositoryComponent"/>
    <service>
       <provide interface="org.eclipse.equinox.p2.core.spi.IAgentServiceFactory"/>
    </service>
-   <property name="p2.agent.servicename" type="String" value="org.eclipse.equinox.p2.repository.artifact.IArtifactRepositoryManager"/>
+   <property name="p2.agent.service.name" type="String" value="org.eclipse.equinox.p2.repository.artifact.IArtifactRepositoryManager"/>
 </scr:component>
diff --git a/.../src/org/eclipse/equinox/internal/p2/artifact/repository/ArtifactRepositoryComponent.java b/.../src/org/eclipse/equinox/internal/p2/artifact/repository/ArtifactRepositoryComponent.java
@@ -7,19 +7,23 @@
  * https://www.eclipse.org/legal/epl-2.0/
  *
  * SPDX-License-Identifier: EPL-2.0
- * 
+ *
  * Contributors:
  *     IBM Corporation - initial API and implementation
  *******************************************************************************/
 package org.eclipse.equinox.internal.p2.artifact.repository;
 
 import org.eclipse.equinox.p2.core.IProvisioningAgent;
+import org.eclipse.equinox.p2.core.spi.AgentServiceName;
 import org.eclipse.equinox.p2.core.spi.IAgentServiceFactory;
 import org.eclipse.equinox.p2.repository.artifact.IArtifactRepositoryManager;
+import org.osgi.service.component.annotations.Component;
 
 /**
  * Service factory providing {@link IArtifactRepositoryManager} instances.
  */
+@Component(service = IAgentServiceFactory.class, name = "org.eclipse.equinox.p2.artifact.repository")
+@AgentServiceName(IArtifactRepositoryManager.class)
 public class ArtifactRepositoryComponent implements IAgentServiceFactory {
 
 	@Override