-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ELK's classloader, not root classloader to discover services #1109
base: master
Are you sure you want to change the base?
Conversation
We will take a look at this issue next year such that this can probably be included in the upcoming 0.10.0 release. |
@soerendomroes - thank you for the first feedback and running the CI. I'll see if I can make the CI green for this PR in the meantime. To add some more context: This would allow ELK to be running in with PlantUML when packaged for example in the IntellIJ AsciiDoc plugin that I maintain. I also assume it would enable the PlantUML Server. |
Update on my previous comment: It seems that this fails for the I assume the serviceloader is not used at all in JS, so a similar way to override the class for JS is the way similar to SVGImage? I didn't try it out yet, some advice would be great on how to proceed here. Or that someone with more experience with |
plugins/org.eclipse.elk.core/src/org/eclipse/elk/core/data/LayoutMetaDataService.java
Outdated
Show resolved
Hide resolved
…ipse-elk#1108) Co-authored-by: Sören Domrös <[email protected]>
904bff4
to
7b03d3c
Compare
Thank you @soerendomroes - I now see the pattern :-D I pushed a change that now made the CI pass green in my fork (https://github.com/ahus1/elk/actions/runs/12469241806 + https://github.com/ahus1/elk/actions/runs/12469241788) |
This will use the
LayoutMetaDataService
's classloader to allow for cases when this JAR and other ELK JARs are loaded in dynamic classloader.The previous logic introduced in #789 would only work if the classes were part of the root classloader.
Closes #1108