Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OrderBySize Rectpacking preprocessor #1095

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Eddykasp
Copy link
Contributor

Setting OrderBySize to true will order nodes by the sizes of their areas while preserving any prior ordering in case of ties.

Setting OrderBySize to true will order nodes by the sizes of their areas
while preserving any prior ordering in case of ties.
@Eddykasp Eddykasp added this to the Release 0.9.2 milestone Dec 11, 2024
@Eddykasp
Copy link
Contributor Author

sonatype appears to be down

Copy link
Contributor

@soerendomroes soerendomroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new option does not work together with interactive positions or does it?

I guess the new processor should be executed before the InteractiveNodeReorderer.

If you do not want it to work with interactivity please state to in the option description.

@Eddykasp
Copy link
Contributor Author

The new option does not work together with interactive positions or does it?

I guess the new processor should be executed before the InteractiveNodeReorderer.

If you do not want it to work with interactivity please state to in the option description.

I think I would allow it together with interactivity, but yes before interactivity makes sense. I don't know if there is a use case but I would allow the Freedom to combine both strategies

@Eddykasp Eddykasp merged commit 37c7ded into eclipse-elk:master Dec 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants