Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitespace elimination is not disabled per default. #1054

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix whitespace elimination is not disabled per default. #1054

merged 1 commit into from
Jul 16, 2024

Conversation

soerendomroes
Copy link
Contributor

Added a default value for whitespace elimination.

Additionally, I added an explicit NONE value, since null may not work as a value for all languages that utilize layout annotation.

@soerendomroes soerendomroes added the alg-rectpacking Affects the ELK RectPacking algorithm. label Jul 16, 2024
@soerendomroes soerendomroes added this to the Release 0.9.2 milestone Jul 16, 2024
@soerendomroes soerendomroes requested a review from Eddykasp July 16, 2024 11:47
Eddykasp
Eddykasp approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@Eddykasp Eddykasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soerendomroes soerendomroes merged commit a2f86e9 into eclipse-elk:master Jul 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddykasp Eddykasp Eddykasp approved these changes

Assignees
No one assigned
Labels
alg-rectpacking Affects the ELK RectPacking algorithm.
Projects
None yet
Milestone
Release 0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@soerendomroes @Eddykasp