Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invocationContext.proceed() is call twice - #254 #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix invocationContext.proceed() is call twice - #254 #295

wants to merge 1 commit into from

Conversation

haducloc
Copy link

Fix invocationContext.proceed() is call twice - #254 in RememberMeInterceptor.java
Signed-off-by: Loc Ha [email protected]

@keilw keilw self-requested a review November 16, 2020 17:58
Copy link
Member

@keilw keilw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but @haducloc you don't seem to have an ECA (Eclipse Contributor Agreement) in place, so we need that before being able to merge or approve this PR?

@keilw
Copy link
Member

keilw commented Dec 10, 2020

@haducloc any progress with your ECA?

@haducloc
Copy link
Author

haducloc commented Dec 16, 2020 via email

@keilw
Copy link
Member

keilw commented Dec 17, 2020

You mean we shall close it?

@ggam
Copy link
Member

ggam commented Dec 17, 2020

Your account still has no ECA associated (https://accounts.eclipse.org/legal/eca/validation/52865). Do you need some assistance with the process?

@keilw
Copy link
Member

keilw commented Dec 17, 2020

Yes, if @haducloc only meant he has troubles to sign the ECA, then hopefully he could get some help to so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants