-
Notifications
You must be signed in to change notification settings - Fork 69
Standalone guides POC #193
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Guillermo González de Agüero <[email protected]>
Signed-off-by: Guillermo González de Agüero <[email protected]>
Signed-off-by: Guillermo González de Agüero <[email protected]>
Signed-off-by: Guillermo González de Agüero <[email protected]>
This is still a draft, I trust the other one can be merged sooner, this one also had over 1k files changed. |
This branch is indeed based on #191 and only makes some additional changes: ggam/jakartaee-tutorial@jbakeless...ggam:split-guides |
@ggam Is this something related to either Jakarta EE 8 support or 9 or is it independent? |
It's independent and will need a rebase after the Jakarta EE 9 changes are
merged.
…On Mon, May 3, 2021 at 10:34 AM Werner Keil ***@***.***> wrote:
@ggam <https://github.com/ggam> Is this something related to either
Jakarta EE 8 support or 9 or is it independent?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#193 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQC44AOKUM72HTBZ7RMDH3TLZNZPANCNFSM4MRI7BAQ>
.
|
@ggam I just merged the Jakarta EE 9 changes ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start, even though POC, let's go ahead with this.
@ggam what shall we do with this PR? This hasn't been updated for almost 2 years. |
Main problem it has it that cross-document links don't work. I thought those were automatically fixed by @hussainnm changes but I've just checked and the problem is still there. Anyway, since this doesn't change the actual contents of the tutorial and it's just an addition to the existing structure, it should be good to merge for now. |
Thanks @ggam, now the only thing is that the build mysteriously fails. Can you try to just re-run it? |
Fixes #192. Requires #191.
This is a very early POC, just for getting feedback. Preview is available at http://www.ggam.eu/jakartaee-tutorial/guides/
I've presented concepts basically in the order they are explained in the full tutorial and arbitrarily grouped it based on personal criteria.