Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add federated catalog samples for an embedded and a standalone federated catalog #342

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

farhin23
Copy link
Contributor

What this PR changes/adds

This PR adds a new module federated-catalog, which includes the following samples,

  • fc-00-basic: includes preparations for the later Federated Catalog samples
  • fc-01-embedded: demonstration of a federated catalog, embedded in a connector.
  • fc-02-standalone: demonstrates the implementation of a standalone catalog.

Why it does that

To illustrate how we can implement different types of Federated Catalogs, e.g embedded and standalone.

Further notes

Projects and libraries have been added in settings.gradle.kts, and gradle/libs.versions.toml.

Linked Issue(s)

Contributes to #296

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@farhin23 farhin23 added the enhancement New feature or request label Nov 19, 2024
@farhin23 farhin23 mentioned this pull request Nov 19, 2024
3 tasks
@ndr-brt ndr-brt self-requested a review November 20, 2024 14:39
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide automated tests on the system-tests module that ensure the samples are working correctly, as done for the other samples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants