fix: #86 sample 04 terminating on startup #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing_on_startup transfer/transfer-04-open-telemetry/open-telemetry-provider/build.gradle.kts
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'
jimmarino
requested changes
Sep 28, 2023
system-tests/src/test/java/org/eclipse/edc/samples/transfer/Transfer04openTelemetryTest.java
Show resolved
Hide resolved
system-tests/src/test/java/org/eclipse/edc/samples/transfer/Transfer04openTelemetryTest.java
Outdated
Show resolved
Hide resolved
…_on_startup' into bugfix/#86_sample_04_terminating_on_startup
hamidonos
changed the title
…_on_startup' into bugfix/#86_sample_04_terminating_on_startup
ndr-brt
approved these changes
Oct 6, 2023
majadlymhmd
pushed a commit
to FraunhoferISST/edc-samples
that referenced
this pull request
Nov 20, 2023
* fix: working sample 04 * test: added test for docker compose sample * style: cosmetic changes * test: temporarily disable progress checking of transfer * docs: added explanation for commented line * test: download OpenTelemetry Jar before test execution * gradle: download OpenTelemetry before build step * removing container name from prometheus as it's not supported by testcontainers * fixed typo in libs.versions.toml * copy opentelemetry jar from gradle cache * fixed default sample tests for sample 04 * fixed build process * asserting Jaeger state OK in telemetry test * fix: fixing wrong testcontainer reference in .toml file * fix: running gradle build before test * fix: removing gradle build before test for github action --------- Co-authored-by: Matthias De Geyter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
fixes #86; commands from README now work.
Why it does that
basically looked at transfer sample 01 and applied all dependencies/variables from there
Further notes
Linked Issue(s)
Closes #127
Closes #86
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.