Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transfer): fix inconsistent TransferProcess id #125

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

saschaisele-zf
Copy link
Contributor

What this PR changes/adds

Uses the same TransferProcess id for steps 9, 10 and 11 in the transfer-06-consumer-pull-http sample to improve consistency.

Why it does that

The different TransferProcess id could lead to misunderstandings according to feedback.

Linked Issue(s)

Closes #124

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'

@ndr-brt ndr-brt added bug Something isn't working documentation Improvements or additions to documentation and removed bug Something isn't working labels Sep 26, 2023
@ndr-brt ndr-brt merged commit e77162e into eclipse-edc:main Sep 26, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent TransferProcess id in transfer-06-consumer-pull-http
3 participants