Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Fix WebTerminal e2e tests #23271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SkorikSergey
Copy link
Contributor

@SkorikSergey SkorikSergey commented Nov 28, 2024

What does this PR do?

We need to fix WebTerminalUnderRegularUser and WebTerminalUnderAdmin e2e test for using them in WTO pre-release automation.

WebTerminalUnderRegularUser test fails because web element to visible. Scrolling fix this problem.

For WebTerminalUnderAdmin test expected tool list should be fixed.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7859

How to test this PR?

Start e2e tests as usual except it is need to change TS_SELENIUM_OCP_USERNAME to user name:
export TS_SELENIUM_OCP_USERNAME="user" for WebTerminalUnderRegularUser
export TS_SELENIUM_OCP_USERNAME="admin" for WebTerminalUnderAdmin

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@SkorikSergey SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. area/qe labels Nov 28, 2024
@SkorikSergey SkorikSergey self-assigned this Nov 28, 2024
@SkorikSergey SkorikSergey marked this pull request as ready for review November 29, 2024 12:53
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qe status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants