Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply linter suggestions #23215

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Apply linter suggestions #23215

merged 1 commit into from
Oct 30, 2024

Conversation

musienko-maxim
Copy link
Contributor

@musienko-maxim musienko-maxim commented Oct 30, 2024

What does this PR do?

  • Trivial commit which fixes linter errors

Screenshot/screencast of this PR

e2e-che-lint

What issues does this PR fix or reference?

How to test this PR?

Just run npm run eslint --fix . command in the catalog with tests

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@dmytro-ndp
Copy link
Contributor

@musienko-maxim : what do you think about adding lint error verification to the EmptyWorkspace PR check https://github.com/eclipse-che/che/blob/main/.github/workflows/pr-check.yml#L96 ?

@dmytro-ndp
Copy link
Contributor

FYI: @SkorikSergey has already fixed lint error by another PR #23216

@musienko-maxim
Copy link
Contributor Author

@musienko-maxim : what do you think about adding lint error verification to the EmptyWorkspace PR check https://github.com/eclipse-che/che/blob/main/.github/workflows/pr-check.yml#L96 ?

+1 I am preparing an issue

@musienko-maxim musienko-maxim merged commit e469487 into main Oct 30, 2024
5 checks passed
@musienko-maxim musienko-maxim deleted the fix-linter-errors branch October 30, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants